Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
requested review from
Copilot and
metacosm
and removed request for
Copilot
|
If you remove todos from code then create associated issues to fix the related problem. Removing the todo doesn't help anything related to technical debt, it just hides it so I don't see how this is an improvement. |
There is already an associated issue in fabroc8 client linked in the code, you mean should we create also in JOSDK repo? see: fabric8io/kubernetes-client#6314
Again, see here explained how TODOs pollutes the code: https://www.javathinking.com/blog/how-to-manage-todo-programming-stuff/?utm_source=chatgpt.com |
Yes, having an issue in the Fabric8 client doesn't help the quality of the code here, as the todo is to replace the local implementation by the one provided by Fabric8 once it's available. That should be quite obvious, reading the todo message.
And reading that blog, it's quite obvious that this todo fits their best practices. |
There was a problem hiding this comment.
Pull request overview
Removes in-code TODO notes from GroupVersionKindPlural#getDefaultPluralFor, aligning the codebase with the stated preference to track follow-ups in issues rather than leaving TODOs in non-WIP code.
Changes:
- Deleted TODO and external link comments above
getDefaultPluralFor.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
But that is the point, there is a message that you read all the time. Even pops up in a todo list. As formulated nicely in that blogpost this is waste of time, where you go back all the time. While the issue in fabric8 is lingering there for more than 1.5 year, and might be just never merged. Yet this pops up all the time in the todo list. So basically that quite bad. I changed the PR to remove the whole comment, will rather have a pointer in that issue, to change this in JOSDK if that ever gets merged. (Not talking about that actually this whole concept of GVKP is very questionable, not used in JOSDK at all) |
|
But I don't want to spend to much energy on this, if we all don't agree on this approach, that is also fine by me :) |
I use todos for development, I alway got caught up on this what is usually unrelated. But I beleive generally is a bad practice to have todos in code when not work in progress.
( https://www.javathinking.com/blog/how-to-manage-todo-programming-stuff/?utm_source=chatgpt.com )
maybe we should rather mar it in the related issue, that needs to be updated in JOSDK
Signed-off-by: Attila Mészáros a_meszaros@apple.com